sv2000 commented on a change in pull request #2633: GOBBLIN-759: Added feature 
to support DistCP to copy files that were …
URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r324484636
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimestampBasedCopyableDataset.java
 ##########
 @@ -73,6 +71,7 @@
   private final VersionSelectionPolicy<TimestampedDatasetVersion> 
versionSelectionPolicy;
   private final ExecutorService executor;
   private final FileSystem srcFs;
+  private final CopyableFileFilter copyableFileFilter;
 
 Review comment:
   This class already has a method copyableFileFilter() that returns a 
HiddenFilter. You can use AndPathFilter to merge this filter with the filter 
specified in member variable copyableFileFilter. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to