[ 
https://issues.apache.org/jira/browse/GOBBLIN-759?focusedWorklogId=312739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312739
 ]

ASF GitHub Bot logged work on GOBBLIN-759:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/19 22:47
            Start Date: 15/Sep/19 22:47
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2633: GOBBLIN-759: 
Added feature to support DistCP to copy files that were …
URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r324484290
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/SelectBetweenTimeBasedPolicy.java
 ##########
 @@ -94,17 +100,25 @@ public SelectBetweenTimeBasedPolicy(Optional<Period> 
minLookBackPeriod, Optional
       public boolean apply(TimestampedDatasetVersion version) {
         return version.getDateTime()
             .plus(SelectBetweenTimeBasedPolicy.this.maxLookBackPeriod.or(new 
Period(DateTime.now().getMillis())))
-            .isAfterNow()
-            && 
version.getDateTime().plus(SelectBetweenTimeBasedPolicy.this.minLookBackPeriod.or(new
 Period(0)))
-                .isBeforeNow();
+            .isAfterNow() && version.getDateTime()
+            .plus(SelectBetweenTimeBasedPolicy.this.minLookBackPeriod.or(new 
Period(0)))
+            .isBeforeNow();
       }
     };
   }
 
   protected static Period getLookBackPeriod(String lookbackTime) {
 
 Review comment:
   Looks like this is just reformatting. Unless there is a reason to reformat, 
leave it as is. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 312739)

> DistCP files modified in last n days within a look back period
> --------------------------------------------------------------
>
>                 Key: GOBBLIN-759
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-759
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Karthik Amarnath
>            Priority: Major
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> *Feature Request:*
>  # DistCP only the files modified in last n days within the look back window.
>  # DistCP will copy only the files modified even when the source file which 
> were NOT modified in last n days in the destination directory.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to