sv2000 commented on a change in pull request #2633: GOBBLIN-759: Added feature 
to support DistCP to copy files that were …
URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r324483733
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimestampBasedCopyableDataset.java
 ##########
 @@ -134,7 +133,11 @@ public TimestampBasedCopyableDataset(FileSystem fs, 
Properties props, Path datas
     } finally {
       ExecutorsUtils.shutdownExecutorService(executor, Optional.of(log));
     }
-    return copyableFileList;
+
+    ConcurrentLinkedQueue<CopyableFile> copyableFilesFilteredList = new 
ConcurrentLinkedQueue<>();
 
 Review comment:
   Do we need ConcurrentLinkedQueue? Seems like List<CopyableFile> should 
suffice?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to