shirshanka commented on a change in pull request #2730: GOBBLIN-876: Expose 
metrics() API in GobblinKafkaConsumerClient to al…
URL: https://github.com/apache/incubator-gobblin/pull/2730#discussion_r325301544
 
 

 ##########
 File path: 
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java
 ##########
 @@ -86,6 +89,15 @@
    */
   public Iterator<KafkaConsumerRecord> consume(KafkaPartition partition, long 
nextOffset, long maxOffset);
 
+  /**
+   * API to return underlying Kafka consumer metrics. The individual 
implementations must translate
+   * org.apache.kafka.common.Metric to Coda Hale Metrics.
+   * @return
+   */
+  public default Map<String, Metric> metrics() {
 
 Review comment:
   since metrics is not a verb... maybe this method should be called 
getMetrics()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to