arekusuri commented on a change in pull request #2722: GOBBLIN-865: Add feature 
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r325343123
 
 

 ##########
 File path: 
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
 ##########
 @@ -779,7 +880,7 @@ public boolean bulkApiLogin() throws Exception {
       BatchInfoList batchInfoList = 
this.bulkConnection.getBatchInfoList(this.bulkJob.getId());
 
 Review comment:
   >>       BatchInfoList batchInfoList = 
this.bulkConnection.getBatchInfoList(this.bulkJob.getId());
   I try not to change the existing code in **getQueryResultIds**. And this 
line is necessary. **getBatchInfoList** function's return value is 
**BatchIdAndResultId** which means a list of resultIds with corresponded batch 
Ids.
   One bulkJobId could have multiple results even though it is not a 
pk-chunking.
   
   I am not use **getQueryResultIds** for pkchunking. If we want to do further 
code refactoring, let's do it in another ticket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to