arekusuri commented on a change in pull request #2722: GOBBLIN-865: Add feature 
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r327247892
 
 

 ##########
 File path: 
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
 ##########
 @@ -598,6 +595,8 @@ public String getTimestampPredicateCondition(String 
column, long value, String v
     String[] batchIdResultIdArray = 
partitionPkChunkingBatchIdResultIterator.next().split(":");
     String batchId = batchIdResultIdArray[0];
     String resultId = batchIdResultIdArray[1];
+    log.info(String.format("PK-Chunking work unit: fetching file for 
(jobId=%s, batchId=%s, resultId=%s) ",
 
 Review comment:
   BTW, we were using this way a lot though. I copied the code :)
   I did some searching in our code, I didn't find good example. Can you pint 
me out a sample code? Are you talking about `MessageFormat`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to