[jira] [Work logged] (GOBBLIN-887) Generalize UniversalKafkaSource to accept Extractor that not extending KafkaExtractor

Wed, 25 Sep 2019 16:57:08 -0700 


     [ 
https://issues.apache.org/jira/browse/GOBBLIN-887?focusedWorklogId=318663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318663
 ]

ASF GitHub Bot logged work on GOBBLIN-887:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Sep/19 23:49
            Start Date: 25/Sep/19 23:49
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2741: [GOBBLIN-887] 
Generialize UniversalKafkaSource to accept Extractor that not extending 
KafkaExtractor
URL: 
https://github.com/apache/incubator-gobblin/pull/2741#issuecomment-535268538
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=h1)
 Report
   > Merging 
[#2741](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/483d42c365ff727d5e6c08a2095ef570f9e22482?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2741      +/-   ##
   ============================================
   + Coverage     45.18%   45.18%   +<.01%     
   - Complexity     8803     8806       +3     
   ============================================
     Files          1889     1889              
     Lines         70595    70595              
     Branches       7746     7746              
   ============================================
   + Hits          31897    31900       +3     
   + Misses        35746    35745       -1     
   + Partials       2952     2950       -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../extractor/extract/kafka/UniversalKafkaSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9Vbml2ZXJzYWxLYWZrYVNvdXJjZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
 | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
   | 
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
 | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `64.81% <0%> (+0.46%)` | `28% <0%> (ø)` | :arrow_down: |
   | 
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
 | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
   | 
[...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2741/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==)
 | `76.51% <0%> (+3.03%)` | `21% <0%> (+3%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=footer).
 Last update 
[483d42c...f7a9f39](https://codecov.io/gh/apache/incubator-gobblin/pull/2741?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 318663)
    Time Spent: 20m  (was: 10m)

> Generalize UniversalKafkaSource  to accept Extractor that not extending 
> KafkaExtractor
> --------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-887
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-887
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to