[
https://issues.apache.org/jira/browse/GOBBLIN-822?focusedWorklogId=319827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319827
]
ASF GitHub Bot logged work on GOBBLIN-822:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 21:03
Start Date: 27/Sep/19 21:03
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2685: [GOBBLIN-822]
Upgrade log4j to log4j2 for LogRouting use-case
URL: https://github.com/apache/incubator-gobblin/pull/2685#discussion_r329250052
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/version/finder/AbstractHiveDatasetVersionFinder.java
##########
@@ -68,7 +68,7 @@
}
final HiveDataset hiveDataset = (HiveDataset) dataset;
- if (!HiveUtils.isPartitioned(hiveDataset.getTable())) {
+ if (!hiveDataset.getTable().isPartitioned()) {
Review comment:
Same comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319827)
Time Spent: 3h (was: 2h 50m)
> upgrade log4j to log4j2
> -----------------------
>
> Key: GOBBLIN-822
> URL: https://issues.apache.org/jira/browse/GOBBLIN-822
> Project: Apache Gobblin
> Issue Type: Sub-task
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> log4j2 has routing appender that would be super useful and probably only way
> to achieve " job specific log files" functionality without meddling around
> fileHandler in log4j.
> Also log4j2 has lot of new functionalities and performance benefits (ref:
> HIVE-11304)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
