[
https://issues.apache.org/jira/browse/GOBBLIN-892?focusedWorklogId=321683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321683
]
ASF GitHub Bot logged work on GOBBLIN-892:
------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/19 05:22
Start Date: 02/Oct/19 05:22
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2747: [GOBBLIN-892]
reverting back bad changes done in PR 2720
URL: https://github.com/apache/incubator-gobblin/pull/2747#discussion_r330375569
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java
##########
@@ -326,11 +326,6 @@ private void
finalizeDatasetStateBeforeCommit(JobState.DatasetState datasetState
// The dataset state is set to FAILED if any task failed and
COMMIT_ON_FULL_SUCCESS is used
datasetState.setState(JobState.RunningState.FAILED);
datasetState.incrementJobFailures();
- Optional<String> taskStateException =
taskState.getTaskFailureException();
- String errMsg = "At least one task did not committed successfully.
Setting dataset state to FAILED. "
- + (taskStateException.isPresent() ? taskStateException.get() :
"Exception not set.");
- log.warn(errMsg);
Review comment:
probably. If so, it's logged in some mapper node, which is hard to locate,
which might be the reason that `finalizeDatasetState1 do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 321683)
Time Spent: 1h (was: 50m)
> fix a bug where we are setting/getting props in dataset state. it is not a
> supported operation.
> -----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-892
> URL: https://issues.apache.org/jira/browse/GOBBLIN-892
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
