[ https://issues.apache.org/jira/browse/GOBBLIN-893?focusedWorklogId=322257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322257 ]
ASF GitHub Bot logged work on GOBBLIN-893: ------------------------------------------ Author: ASF GitHub Bot Created on: 02/Oct/19 20:58 Start Date: 02/Oct/19 20:58 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2748: [GOBBLIN-893]Make format-check in ORC-registration optional and by-default disabled URL: https://github.com/apache/incubator-gobblin/pull/2748#issuecomment-537677782 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=h1) Report > Merging [#2748](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/37078ed6a40f73b2560863e3f73e0e1d67c05c87?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2748 +/- ## ============================================ + Coverage 45.22% 45.25% +0.03% - Complexity 8815 8822 +7 ============================================ Files 1889 1889 Lines 70612 70609 -3 Branches 7753 7753 ============================================ + Hits 31933 31957 +24 + Misses 35725 35701 -24 + Partials 2954 2951 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...g/apache/gobblin/hive/orc/HiveOrcSerDeManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL29yYy9IaXZlT3JjU2VyRGVNYW5hZ2VyLmphdmE=) | `66.66% <100%> (+0.4%)` | `12 <0> (ø)` | :arrow_down: | | [...main/java/org/apache/gobblin/runtime/JobState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSm9iU3RhdGUuamF2YQ==) | `75.28% <0%> (-0.29%)` | `58% <0%> (ø)` | | | [...ain/java/org/apache/gobblin/runtime/TaskState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlLmphdmE=) | `81.97% <0%> (+1.16%)` | `32% <0%> (ø)` | :arrow_down: | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | | [...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=) | `66.43% <0%> (+4.79%)` | `25% <0%> (+3%)` | :arrow_up: | | [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2748/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `47.31% <0%> (+7.6%)` | `29% <0%> (+4%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=footer). Last update [37078ed...ccc018e](https://codecov.io/gh/apache/incubator-gobblin/pull/2748?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 322257) Time Spent: 0.5h (was: 20m) > Make ORC-format checking optional in ORC-registration > ----------------------------------------------------- > > Key: GOBBLIN-893 > URL: https://issues.apache.org/jira/browse/GOBBLIN-893 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Lei Sun > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)