yukuai518 commented on a change in pull request #2753: [GOBBLIN-899]Add config 
in replication config to determine wheter schema cehck ena…
URL: https://github.com/apache/incubator-gobblin/pull/2753#discussion_r332654552
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/replication/ReplicationConfiguration.java
 ##########
 @@ -193,6 +201,11 @@ public Builder 
withEnforceFileSizeMatchFromConfigStore(Config config) {
       return this;
     }
 
+    public Builder withSchemaCheckEnabled(Config config) {
+      this.schemaCheckEnabled = !config.hasPath(COPY_SCHEMA_CHECK_ENABLED) || 
config.getBoolean(COPY_SCHEMA_CHECK_ENABLED);
 
 Review comment:
   Consider to use ConfigUtils.getConfig(config, COPY_SCHEMA_CHECK_ENABLED, 
DEFAULT_COPY_SCHEMA_CHECK_ENABLED)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to