[ 
https://issues.apache.org/jira/browse/GOBBLIN-899?focusedWorklogId=325227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325227
 ]

ASF GitHub Bot logged work on GOBBLIN-899:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/19 18:05
            Start Date: 08/Oct/19 18:05
    Worklog Time Spent: 10m 
      Work Description: yukuai518 commented on pull request #2753: 
[GOBBLIN-899]Add config in replication config to determine wheter schema cehck 
ena…
URL: https://github.com/apache/incubator-gobblin/pull/2753#discussion_r332654552
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/replication/ReplicationConfiguration.java
 ##########
 @@ -193,6 +201,11 @@ public Builder 
withEnforceFileSizeMatchFromConfigStore(Config config) {
       return this;
     }
 
+    public Builder withSchemaCheckEnabled(Config config) {
+      this.schemaCheckEnabled = !config.hasPath(COPY_SCHEMA_CHECK_ENABLED) || 
config.getBoolean(COPY_SCHEMA_CHECK_ENABLED);
 
 Review comment:
   Consider to use ConfigUtils.getConfig(config, COPY_SCHEMA_CHECK_ENABLED, 
DEFAULT_COPY_SCHEMA_CHECK_ENABLED)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 325227)
    Time Spent: 1h  (was: 50m)

> Add a key in dataset config to disable schema check for a specific dataset
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-899
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-899
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to