[ 
https://issues.apache.org/jira/browse/GOBBLIN-899?focusedWorklogId=325268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325268
 ]

ASF GitHub Bot logged work on GOBBLIN-899:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/19 18:29
            Start Date: 08/Oct/19 18:29
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on pull request #2753: 
[GOBBLIN-899]Add config in replication config to determine wheter schema cehck 
ena…
URL: https://github.com/apache/incubator-gobblin/pull/2753#discussion_r332666140
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/extractor/FileAwareInputStreamExtractorWithCheckSchema.java
 ##########
 @@ -66,14 +67,19 @@ protected FileAwareInputStream buildStream(FileSystem 
fsFromFile) throws DataRec
    * @throws IOException
    */
   protected boolean schemaChecking(FileSystem fsFromFile) throws IOException {
+    if( 
!this.state.getPropAsBoolean(ReplicationConfiguration.COPY_SCHEMA_CHECK_ENABLED,
 false) ) {
+      return true;
+    }
     DatumReader<GenericRecord> datumReader = new GenericDatumReader<>();
     DataFileReader<GenericRecord> dataFileReader =
         new DataFileReader(new FsInput(this.file.getFileStatus().getPath(), 
new Configuration()), datumReader);
 
 Review comment:
   There is no existing generic logic to read schema because the schema need to 
be read by specific reader. And the next PR should enable schema check for ORC 
schema as well. But it will be implemented by an if else statement which is 
also not generic.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 325268)
    Time Spent: 1h 10m  (was: 1h)

> Add a key in dataset config to disable schema check for a specific dataset
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-899
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-899
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to