sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782155
########## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java ########## @@ -403,11 +403,11 @@ private void setWorkUnitWatermark(WorkUnit workUnit, Optional<CopyableFileWaterm private void addLineageInfo(CopyEntity copyEntity, WorkUnit workUnit) { if (copyEntity instanceof CopyableFile) { CopyableFile copyableFile = (CopyableFile) copyEntity; - /* - * In Gobblin Distcp, the source and target path info of a CopyableFile are determined by its dataset found by - * a DatasetFinder. Consequently, the source and destination dataset for the CopyableFile lineage are expected - * to be set by the same logic - */ + /* Review comment: Looks like the change to CopySource is unintentional. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services