Will-Lo opened a new pull request #2759: [GOBBLIN-905] Fixes issue where newly 
added jobs would crash in gobbl…
URL: https://github.com/apache/incubator-gobblin/pull/2759
 
 
   …in standalone's job conf folder
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-905
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   
   Currently Gobblin Standalone crashes when adding a new `.job` file to 
`GOBBLIN_JOB_CONF_DIR`. Bug reproduction steps and output is outlined in the 
Jira ticket.
   
   Bug was caused by `JobSpecResolver` being null when 
`PathAlterationListenerAdaptorForMonitor` is instantiated. Fix moved the 
assignment of `JobSpecResolver` to be before the instantiation.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to