ASF GitHub Bot logged work on GOBBLIN-905:

                Author: ASF GitHub Bot
            Created on: 09/Oct/19 22:34
            Start Date: 09/Oct/19 22:34
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on pull request #2759: [GOBBLIN-905] 
Fixes issue where newly added jobs would crash in gobbl…
URL: https://github.com/apache/incubator-gobblin/pull/2759
   …in standalone's job conf folder
   Dear Gobblin maintainers,
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-905
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
   Currently Gobblin Standalone crashes when adding a new `.job` file to 
`GOBBLIN_JOB_CONF_DIR`. Bug reproduction steps and output is outlined in the 
Jira ticket.
   Bug was caused by `JobSpecResolver` being null when 
`PathAlterationListenerAdaptorForMonitor` is instantiated. Fix moved the 
assignment of `JobSpecResolver` to be before the instantiation.
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 325967)
    Time Spent: 0.5h  (was: 20m)

> Gobblin standalone crashes when adding a new job to its tracked folder
> ----------------------------------------------------------------------
>                 Key: GOBBLIN-905
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-905
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> Gobblin standalone crashes with a null pointer exception when adding a new 
> `.job` file to its tracked directory.
> To reproduce, add a `.job` file in `GOBBLIN_JOB_CONF_DIR`
> Produced output is below
> {quote}2019-10-08 22:38:29 GMT ERROR [newDaemonThreadFactory] 
> org.apache.gobblin.util.filesystem.ExceptionCatchingPathAlterationListenerDecorator
>   57 - onFileCreate failure:
> java.lang.NullPointerException
>       at 
> org.apache.gobblin.util.SchedulerUtils.resolveTemplate(SchedulerUtils.java:182)
>       at 
> org.apache.gobblin.util.SchedulerUtils.loadGenericJobConfig(SchedulerUtils.java:139)
>       at 
> org.apache.gobblin.scheduler.PathAlterationListenerAdaptorForMonitor.loadNewJobConfigAndHandleNewJob(PathAlterationListenerAdaptorForMonitor.java:79)
>       at 
> org.apache.gobblin.scheduler.PathAlterationListenerAdaptorForMonitor.onFileCreate(PathAlterationListenerAdaptorForMonitor.java:165)
>       at 
> org.apache.gobblin.util.filesystem.ExceptionCatchingPathAlterationListenerDecorator.onFileCreate(ExceptionCatchingPathAlterationListenerDecorator.java:55)
>       at 
> org.apache.gobblin.util.filesystem.PathAlterationObserver.doCreate({quote}

This message was sent by Atlassian Jira

Reply via email to