autumnust commented on a change in pull request #2762: [GOBBLIN-908] Customized Progress to enable speculative execution URL: https://github.com/apache/incubator-gobblin/pull/2762#discussion_r335176385
########## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java ########## @@ -832,6 +871,10 @@ public void execute() throws IOException { LOG.info("Adding additional commit step"); gobblinMultiTaskAttempt.addCleanupCommitStep(cleanUpCommitStep); } + // Finishing of Mapper declares the actually execution finished, safe to report 1.0f. + if (customizedProgressEnabled) { Review comment: Will address. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services