[
https://issues.apache.org/jira/browse/GOBBLIN-916?focusedWorklogId=331649&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331649
]
ASF GitHub Bot logged work on GOBBLIN-916:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/19 21:07
Start Date: 21/Oct/19 21:07
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2770: [GOBBLIN-916] Make
ContainerLaunchContext instantiation in YarnService more efficient
URL:
https://github.com/apache/incubator-gobblin/pull/2770#issuecomment-544708336
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=h1)
Report
> Merging
[#2770](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/b92f516a4e7a9b2c8bd2e90d71026fb07cb56da7?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `2.56%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2770 +/- ##
============================================
+ Coverage 45.3% 45.32% +0.01%
- Complexity 8846 8858 +12
============================================
Files 1892 1894 +2
Lines 70752 70861 +109
Branches 7773 7790 +17
============================================
+ Hits 32054 32116 +62
- Misses 35740 35784 +44
- Partials 2958 2961 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `14.92% <100%> (+0.08%)` | `3 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <0%> (-6.55%)` | `11% <0%> (-2%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.35% <0%> (-0.47%)` | `28% <0%> (ø)` | |
|
[...ement/copy/UnixTimestampCopyableDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVW5peFRpbWVzdGFtcENvcHlhYmxlRGF0YXNldEZpbmRlci5qYXZh)
| `100% <0%> (ø)` | `2% <0%> (?)` | |
|
[...nt/copy/UnixTimestampRecursiveCopyableDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvVW5peFRpbWVzdGFtcFJlY3Vyc2l2ZUNvcHlhYmxlRGF0YXNldC5qYXZh)
| `85% <0%> (ø)` | `8% <0%> (?)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `79.29% <0%> (+0.29%)` | `12% <0%> (ø)` | :arrow_down: |
|
[...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh)
| `84.81% <0%> (+0.81%)` | `34% <0%> (+2%)` | :arrow_up: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
| ... and [2
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2770/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=footer).
Last update
[b92f516...08823cb](https://codecov.io/gh/apache/incubator-gobblin/pull/2770?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 331649)
Time Spent: 40m (was: 0.5h)
> Make ContainerLaunchContext instantiation in YarnService more efficient
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-916
> URL: https://issues.apache.org/jira/browse/GOBBLIN-916
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
