autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance
DDL to add column and column.types with case-preserving schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341363858
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java
##########
@@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity
generatePublishQueries() throws DataConversio
Map<String, String> publishDirectories =
publishEntity.getPublishDirectories();
List<String> cleanupQueries = publishEntity.getCleanupQueries();
List<String> cleanupDirectories = publishEntity.getCleanupDirectories();
+ Optional<Schema> avroSchema = Optional.absent();
Review comment:
I might be wrong but is this method being called through the conversion
jobs? By briefly looking at the code base, this `generatePublishQueries` method
is only called in
`org.apache.gobblin.data.management.conversion.hive.materializer.HiveMaterializer#generatePublishQueries`
which is not related to Avro2ORC, just want to confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
