ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance 
DDL to add column and column.types with case-preserving schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341419272
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
 ##########
 @@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
     //    .. use columns from destination schema
     if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
       log.info("Generating DDL using source schema");
+      System.out.println("Generating DDL using source schema");
       ddl.append(generateAvroToHiveColumnMapping(schema, 
Optional.of(hiveColumns), true, dbName + "." + tblName));
+      try {
 
 Review comment:
   Yes, at least it's enabled in scoreevent. BTW, can you look at the new pr 
for this commit? I have sent you the email. Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to