autumnust commented on a change in pull request #2792: [GOBBLIN-933] add
support for array of unions in json schema
URL: https://github.com/apache/incubator-gobblin/pull/2792#discussion_r341800826
##########
File path:
gobblin-core/src/test/java/org/apache/gobblin/converter/avro/JsonRecordAvroSchemaToAvroConverterTest.java
##########
@@ -85,5 +85,17 @@ public void testConverter()
Assert.assertEquals(recordInArray.get("field1").toString(), "test1");
Assert.assertEquals((record.get("enumField")).toString(), "ENUM2");
+
+ Assert.assertTrue(record.get("arrayFieldWithUnion") instanceof
GenericArray);
Review comment:
Please add more cases for this converter which is pretty unit-testable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
