[
https://issues.apache.org/jira/browse/GOBBLIN-944?focusedWorklogId=337892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337892
]
ASF GitHub Bot logged work on GOBBLIN-944:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/19 00:49
Start Date: 04/Nov/19 00:49
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2794: [GOBBLIN-944]
Provide the flexibility of deriving platform field in a different way for
subclasses of BaseDatasetDescriptor
URL:
https://github.com/apache/incubator-gobblin/pull/2794#issuecomment-549197573
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=h1)
Report
> Merging
[#2794](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/94a508b38ec8bd879614f2d9bf0eeb96513ca7cf?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2794 +/- ##
============================================
+ Coverage 45.32% 45.33% +0.01%
- Complexity 8862 8865 +3
============================================
Files 1894 1894
Lines 70910 70911 +1
Branches 7799 7799
============================================
+ Hits 32141 32150 +9
+ Misses 35803 35798 -5
+ Partials 2966 2963 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...service/modules/dataset/BaseDatasetDescriptor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0Jhc2VEYXRhc2V0RGVzY3JpcHRvci5qYXZh)
| `73.33% <100%> (+0.91%)` | `14 <1> (+1)` | :arrow_up: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
|
[...he/gobblin/writer/FineGrainedWatermarkTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL0ZpbmVHcmFpbmVkV2F0ZXJtYXJrVHJhY2tlci5qYXZh)
| `84.67% <0%> (+2.41%)` | `29% <0%> (+1%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2794/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=footer).
Last update
[94a508b...91c57c1](https://codecov.io/gh/apache/incubator-gobblin/pull/2794?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 337892)
Time Spent: 0.5h (was: 20m)
> Provide the flexibility of deriving platform field in a different way for
> subclasses of BaseDatasetDescriptor
> -------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-944
> URL: https://issues.apache.org/jira/browse/GOBBLIN-944
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current BaseDatasetDescriptor always gets the platform from the configuration
> object, but there could be use cases where the platform is derived in a
> different way. We need to change the implementation of BaseDatasetDescriptor
> constructor such that derived classes have the flexibility to change this
> default behaviour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
