[
https://issues.apache.org/jira/browse/GOBBLIN-945?focusedWorklogId=338899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-338899
]
ASF GitHub Bot logged work on GOBBLIN-945:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 17:51
Start Date: 05/Nov/19 17:51
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2795: GOBBLIN-945:
Refactor Kafka extractor statistics tracking to allow co…
URL: https://github.com/apache/incubator-gobblin/pull/2795
…de reuse across both batch and streaming execution modes
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-945
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Current implementation of kafka extractor stats tracking is deeply
integrated with the batch implementation of KafkaExtractor preventing it from
being used in streaming Kafka extractor implementations. In addition to code
reuse, the refactoring allows for writing unit tests for statistics tracker.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added unit tests to KafkaExtractorStatsTrackerTest class.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 338899)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor Kafka extractor statistics tracking to allow code reuse across both
> batch and streaming execution modes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-945
> URL: https://issues.apache.org/jira/browse/GOBBLIN-945
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current implementation of kafka extractor stats tracking is deeply integrated
> with the batch implementation of KafkaExtractor preventing it from being used
> in streaming Kafka extractor implementations. In addition to code reuse, the
> refactoring allows for writing unit tests for statistics tracker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
