sv2000 commented on a change in pull request #2795: GOBBLIN-945: Refactor Kafka extractor statistics tracking to allow co… URL: https://github.com/apache/incubator-gobblin/pull/2795#discussion_r342928259
########## File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaPartition.java ########## @@ -31,6 +31,7 @@ private final int id; private final String topicName; private KafkaLeader leader; + private int hashCode; Review comment: Hmm. I can, but is there a significant benefit to using auto-generated hashCode? The only change I am making here is to cache the hashCode to avoid re-computing it every time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
