[
https://issues.apache.org/jira/browse/GOBBLIN-945?focusedWorklogId=339174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339174
]
ASF GitHub Bot logged work on GOBBLIN-945:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 06:03
Start Date: 06/Nov/19 06:03
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2795: GOBBLIN-945:
Refactor Kafka extractor statistics tracking to allow co…
URL: https://github.com/apache/incubator-gobblin/pull/2795#discussion_r342928259
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaPartition.java
##########
@@ -31,6 +31,7 @@
private final int id;
private final String topicName;
private KafkaLeader leader;
+ private int hashCode;
Review comment:
Hmm. I can, but is there a significant benefit to using auto-generated
hashCode? The only change I am making here is to cache the hashCode to avoid
re-computing it every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339174)
Time Spent: 2h (was: 1h 50m)
> Refactor Kafka extractor statistics tracking to allow code reuse across both
> batch and streaming execution modes
> ----------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-945
> URL: https://issues.apache.org/jira/browse/GOBBLIN-945
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Current implementation of kafka extractor stats tracking is deeply integrated
> with the batch implementation of KafkaExtractor preventing it from being used
> in streaming Kafka extractor implementations. In addition to code reuse, the
> refactoring allows for writing unit tests for statistics tracker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
