sv2000 commented on a change in pull request #2797: [GOBBLIN-948] add hive data node and descriptor URL: https://github.com/apache/incubator-gobblin/pull/2797#discussion_r343254487
########## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/HiveDatasetDescriptor.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.dataset; + +import java.io.IOException; + +import com.typesafe.config.Config; + +import lombok.EqualsAndHashCode; + + +/** + * As of now, {@link HiveDatasetDescriptor} has same implementation as that of {@link SqlDatasetDescriptor}. + * It can have partitioning related information in the future. + */ +@EqualsAndHashCode (callSuper = true) +public class HiveDatasetDescriptor extends SqlDatasetDescriptor { + + public HiveDatasetDescriptor(Config config) throws IOException { Review comment: I think HiveDatasetDescriptor can be enhanced with some additional metadata e.g a field to flag if the Hive dataset is partitioned or non-partitioned, a property to indicate partitioning type e.g. datetime and then a property to describe datetime pattern (e.g. YYYY-MM-DD etc.). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
