[ 
https://issues.apache.org/jira/browse/GOBBLIN-950?focusedWorklogId=340174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340174
 ]

ASF GitHub Bot logged work on GOBBLIN-950:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/19 21:50
            Start Date: 07/Nov/19 21:50
    Worklog Time Spent: 10m 
      Work Description: haojiliu commented on pull request #2798: [GOBBLIN-950] 
Avoid persisting dag right after loading it on startup
URL: https://github.com/apache/incubator-gobblin/pull/2798#discussion_r343892812
 
 

 ##########
 File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -243,6 +247,10 @@ synchronized void addDag(Dag<JobExecutionPlan> dag) 
throws IOException {
     submitEventsAndSetStatus(dag);
   }
 
+  synchronized void addDag(Dag<JobExecutionPlan> dag) throws IOException {
 
 Review comment:
   Is this for backwards compatibility? I'm curious why we need an extra 
function for implicit persistence. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 340174)
    Time Spent: 20m  (was: 10m)

> GaaS unnecessarily persists dag right after loading it on startup
> -----------------------------------------------------------------
>
>                 Key: GOBBLIN-950
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-950
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to