jack-moseley commented on a change in pull request #2798: [GOBBLIN-950] Avoid
persisting dag right after loading it on startup
URL: https://github.com/apache/incubator-gobblin/pull/2798#discussion_r343914010
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -243,6 +247,10 @@ synchronized void addDag(Dag<JobExecutionPlan> dag)
throws IOException {
submitEventsAndSetStatus(dag);
}
+ synchronized void addDag(Dag<JobExecutionPlan> dag) throws IOException {
Review comment:
Mainly just to provide a default value since some unit tests call this, but
yeah maybe it's better to update all the callers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
