[jira] [Work logged] (GOBBLIN-953) Add scoped config for app launcher created by gobblin service

Fri, 08 Nov 2019 15:00:53 -0800 


     [ 
https://issues.apache.org/jira/browse/GOBBLIN-953?focusedWorklogId=340798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340798
 ]

ASF GitHub Bot logged work on GOBBLIN-953:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/19 22:59
            Start Date: 08/Nov/19 22:59
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2801: [GOBBLIN-953] Add 
scoped config for app launcher created by gobblin service
URL: 
https://github.com/apache/incubator-gobblin/pull/2801#issuecomment-552023566
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=h1)
 Report
   > Merging 
[#2801](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/4efc5fb6d8f16b56e8fc1858c8093a150353a348?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2801      +/-   ##
   ============================================
   - Coverage     45.47%   45.46%   -0.02%     
   + Complexity     8899     8896       -3     
   ============================================
     Files          1897     1897              
     Lines         71016    71017       +1     
     Branches       7817     7817              
   ============================================
   - Hits          32298    32289       -9     
   - Misses        35742    35750       +8     
   - Partials       2976     2978       +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../org/apache/gobblin/service/ServiceConfigKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9TZXJ2aWNlQ29uZmlnS2V5cy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `54.75% <83.33%> (+0.17%)` | `25 <0> (ø)` | :arrow_down: |
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `63.42% <0%> (-1.86%)` | `27% <0%> (-1%)` | |
   | 
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2801/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
 | `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=footer).
 Last update 
[4efc5fb...454b178](https://codecov.io/gh/apache/incubator-gobblin/pull/2801?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 340798)
    Time Spent: 0.5h  (was: 20m)

> Add scoped config for app launcher created by gobblin service
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-953
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-953
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to