[
https://issues.apache.org/jira/browse/GOBBLIN-956?focusedWorklogId=341580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341580
]
ASF GitHub Bot logged work on GOBBLIN-956:
------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 01:10
Start Date: 12/Nov/19 01:10
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2805: [GOBBLIN-956]
Continue loading dags until queue is drained
URL:
https://github.com/apache/incubator-gobblin/pull/2805#issuecomment-552687772
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=h1)
Report
> Merging
[#2805](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/3c1efb9c4608d8ff0c93395117d2136a82565851?src=pr&el=desc)
will **decrease** coverage by `0.95%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2805 +/- ##
============================================
- Coverage 45.47% 44.52% -0.96%
+ Complexity 8905 8736 -169
============================================
Files 1899 1899
Lines 71068 71070 +2
Branches 7825 7826 +1
============================================
- Hits 32320 31643 -677
- Misses 35764 36487 +723
+ Partials 2984 2940 -44
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `78.91% <50%> (-0.16%)` | `12 <0> (ø)` | |
|
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh)
| `0% <0%> (-83.34%)` | `0% <0%> (-1%)` | |
|
[...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=)
| `0% <0%> (-80.77%)` | `0% <0%> (-7%)` | |
|
[...lin/runtime/locks/LegacyJobLockFactoryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvTGVnYWN5Sm9iTG9ja0ZhY3RvcnlNYW5hZ2VyLmphdmE=)
| `0% <0%> (-78.58%)` | `0% <0%> (-2%)` | |
|
[.../apache/gobblin/metastore/ZkStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1prU3RhdGVTdG9yZUZhY3RvcnkuamF2YQ==)
| `0% <0%> (-71.43%)` | `0% <0%> (-2%)` | |
|
[...he/gobblin/runtime/ZkDatasetStateStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlRmFjdG9yeS5qYXZh)
| `0% <0%> (-71.43%)` | `0% <0%> (-2%)` | |
|
[...apache/gobblin/runtime/MysqlDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTXlzcWxEYXRhc2V0U3RhdGVTdG9yZS5qYXZh)
| `0% <0%> (-70%)` | `0% <0%> (-7%)` | |
| ... and [41
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2805/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=footer).
Last update
[3c1efb9...b5b99e6](https://codecov.io/gh/apache/incubator-gobblin/pull/2805?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 341580)
Time Spent: 20m (was: 10m)
> Change DagManagerThread to continue running until queue of dags is drained
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-956
> URL: https://issues.apache.org/jira/browse/GOBBLIN-956
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
