[
https://issues.apache.org/jira/browse/GOBBLIN-957?focusedWorklogId=342278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342278
]
ASF GitHub Bot logged work on GOBBLIN-957:
------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 23:21
Start Date: 12/Nov/19 23:21
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2806: GOBBLIN-957: Add
recursion eliminating converter for Avro
URL:
https://github.com/apache/incubator-gobblin/pull/2806#issuecomment-553080330
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=h1)
Report
> Merging
[#2806](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/3c1efb9c4608d8ff0c93395117d2136a82565851?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `74.35%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2806 +/- ##
============================================
+ Coverage 45.47% 45.52% +0.04%
- Complexity 8905 8925 +20
============================================
Files 1899 1900 +1
Lines 71068 71144 +76
Branches 7825 7834 +9
============================================
+ Hits 32320 32385 +65
- Misses 35764 35773 +9
- Partials 2984 2986 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...verter/avro/AvroRecursionEliminatingConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0F2cm9SZWN1cnNpb25FbGltaW5hdGluZ0NvbnZlcnRlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=)
| `57.61% <90.62%> (+8.84%)` | `77 <17> (+22)` | :arrow_up: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <0%> (-2.81%)` | `11% <0%> (-1%)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `14.84% <0%> (-0.85%)` | `3% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.35% <0%> (+0.92%)` | `27% <0%> (ø)` | :arrow_down: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
| ... and [1
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2806/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=footer).
Last update
[3c1efb9...00c3ff3](https://codecov.io/gh/apache/incubator-gobblin/pull/2806?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342278)
Remaining Estimate: 0h
Time Spent: 10m
> Support automatic recursion removal from schemas
> ------------------------------------------------
>
> Key: GOBBLIN-957
> URL: https://issues.apache.org/jira/browse/GOBBLIN-957
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Shirshanka Das
> Assignee: Shirshanka Das
> Priority: Major
> Labels: avro
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Analytics engines like Hive etc cannot handle recursive schemas: schemas
> where inner fields can refer to the wrapping type.
> This Jira proposes that we provide support for automatic recursion removal in
> data during data ingestion.
> The simple proposal is to just drop the fields in the schema that introduce
> the recursion.
> e.g. (pseudo-schema)
> User {
> string name;
> User friend;
> }
> gets converted to :
> User {
> string name;
> }
>
> A more sophisticated solution would be to do one or two levels of
> "schema-unrolling" before dropping data.
> e.g.
> output schema with one-level unrolling would look like:
> User {
> string name;
> User1 friend;
> }
> User 1 {
> string name;
> }
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
