[
https://issues.apache.org/jira/browse/GOBBLIN-966?focusedWorklogId=344545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344545
]
ASF GitHub Bot logged work on GOBBLIN-966:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/19 20:10
Start Date: 15/Nov/19 20:10
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2812: GOBBLIN-966:
Check if no partitions have been processed by KafkaExtra…
URL: https://github.com/apache/incubator-gobblin/pull/2812
…ctor in close() method to avoid ArrayIndexOutOfBoundsException
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-966
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
When no partitions are processed by KafkaExtractor, the
currentPartitionIndex remains at -1. Calling the
KafkaExtractorStatsTracker#updateStatisticsForCurrentPartition() method, with a
partition index of -1 causes ArrayIndexOutofBoundsException.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Trivial.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344545)
Remaining Estimate: 0h
Time Spent: 10m
> Check if no partitions have been processed by KafkaExtractor in close()
> method to avoid ArrayIndexOutOfBoundsException
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-966
> URL: https://issues.apache.org/jira/browse/GOBBLIN-966
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Minor
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When no partitions are processed by KafkaExtractor, the currentPartitionIndex
> remains at -1. Calling the
> KafkaExtractorStatsTracker#updateStatisticsForCurrentPartition() method, with
> a partition index of -1 causes ArrayIndexOutofBoundsException.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
