[
https://issues.apache.org/jira/browse/GOBBLIN-967?focusedWorklogId=344750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344750
]
ASF GitHub Bot logged work on GOBBLIN-967:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/19 02:02
Start Date: 16/Nov/19 02:02
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2813: [GOBBLIN-967]
Change token refresh method in YarnContainerSecirityManager
URL:
https://github.com/apache/incubator-gobblin/pull/2813#issuecomment-554593087
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=h1)
Report
> Merging
[#2813](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/9f0218b276dbf18cd31af11642dcf23230ebcdfc?src=pr&el=desc)
will **increase** coverage by `0.07%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2813 +/- ##
============================================
+ Coverage 45.49% 45.57% +0.07%
- Complexity 8921 8955 +34
============================================
Files 1899 1900 +1
Lines 71132 71213 +81
Branches 7846 7856 +10
============================================
+ Hits 32363 32455 +92
+ Misses 35786 35777 -9
+ Partials 2983 2981 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...che/gobblin/yarn/YarnContainerSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkNvbnRhaW5lclNlY3VyaXR5TWFuYWdlci5qYXZh)
| `63.63% <83.33%> (+11.46%)` | `5 <3> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.88% <0%> (-0.93%)` | `27% <0%> (-1%)` | |
|
[...verter/avro/AvroRecursionEliminatingConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0F2cm9SZWN1cnNpb25FbGltaW5hdGluZ0NvbnZlcnRlci5qYXZh)
| `75% <0%> (ø)` | `5% <0%> (?)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==)
| `76.51% <0%> (+3.03%)` | `21% <0%> (+3%)` | :arrow_up: |
|
[...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=)
| `58.16% <0%> (+9.39%)` | `80% <0%> (+25%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2813/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=footer).
Last update
[9f0218b...c1a0350](https://codecov.io/gh/apache/incubator-gobblin/pull/2813?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344750)
Time Spent: 0.5h (was: 20m)
> Change token refresh method in YarnContainerSecirityManager
> -----------------------------------------------------------
>
> Key: GOBBLIN-967
> URL: https://issues.apache.org/jira/browse/GOBBLIN-967
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Change token refresh method in YarnContainerSecirityManager from adding token
> to directly adding credentials to make sure all the new credentials will be
> updated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
