[ https://issues.apache.org/jira/browse/GOBBLIN-968?focusedWorklogId=345602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345602 ]
ASF GitHub Bot logged work on GOBBLIN-968: ------------------------------------------ Author: ASF GitHub Bot Created on: 18/Nov/19 21:40 Start Date: 18/Nov/19 21:40 Worklog Time Spent: 10m Work Description: chiragtodarka commented on pull request #2816: [GOBBLIN-968] Honor file split size for HadoopFileInputSource URL: https://github.com/apache/incubator-gobblin/pull/2816 Set the value of SPLIT_MAXSIZE and SPLIT_MINSIZE in FileInputFormat class from the configs (source.hadoop.file.input.split.minsize and source.hadoop.file.input.split.maxsize) passed from .pull file. Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-968 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): NA ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: It is passing configs from .pull to set properties in 'Job' object, no separate unit test case needed. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 345602) Remaining Estimate: 23h 50m (was: 24h) Time Spent: 10m > Honor file split size for HadoopFileInputSource > ----------------------------------------------- > > Key: GOBBLIN-968 > URL: https://issues.apache.org/jira/browse/GOBBLIN-968 > Project: Apache Gobblin > Issue Type: Bug > Components: gobblin-core > Affects Versions: 0.14.0 > Reporter: Chirag Todarka > Assignee: Abhishek Tiwari > Priority: Major > Labels: easyfix > Original Estimate: 24h > Time Spent: 10m > Remaining Estimate: 23h 50m > > For HadoopFileInputSource it is splitting the source file only in default > chunk size (which is 128MB) and not honoring the min and mix split size > mentioned in pull file. > For example even if below entires are present in pull file it will still > chunk the source file in smaller 134217728 bytes files and not in 268435456 > bytes files. > {{source.hadoop.file.input.split.minsize=268435456}} > {{source.hadoop.file.input.split.maxsize=268435456}} -- This message was sent by Atlassian Jira (v8.3.4#803005)