[
https://issues.apache.org/jira/browse/GOBBLIN-971?focusedWorklogId=346357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346357
]
ASF GitHub Bot logged work on GOBBLIN-971:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 23:39
Start Date: 19/Nov/19 23:39
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2819:
[GOBBLIN-971]Enable speculative execution awareness for RowQualityChecker
URL: https://github.com/apache/incubator-gobblin/pull/2819
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] https://issues.apache.org/jira/browse/GOBBLIN-971
### Description
- [x]
Problem:
When speculative execution is enabled with ERR_FILE set as the policy when
encountering records that failed rowPolicy, we will run into HDFS file lease
contention since the file name are only depends on `state.getId()`.
Solution: To maintain backward-compatibility we allow speculative-execution
to happen by default, but whenever the policy is set to `ERR_FILE` , we created
different file name for speculative execution. This won't guarantee
contention-free as different execution environment could coincidentally give
identical timestamp, but the chances are pretty low.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 346357)
Remaining Estimate: 0h
Time Spent: 10m
> Enable speculative execution awareness for RowQualityChecker
> ------------------------------------------------------------
>
> Key: GOBBLIN-971
> URL: https://issues.apache.org/jira/browse/GOBBLIN-971
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
