autumnust commented on a change in pull request #2823: GOBBLIN-976: Add dynamic
config to the state before instantiating met…
URL: https://github.com/apache/incubator-gobblin/pull/2823#discussion_r349381535
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -766,6 +767,7 @@ protected void setup(Context context) {
for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
this.jobState.setProp(entry.getKey(),
entry.getValue().unwrapped().toString());
configuration.set(entry.getKey(),
entry.getValue().unwrapped().toString());
+ gobblinJobState.setProp(entry.getKey(),
entry.getValue().unwrapped().toString());
Review comment:
Is there anyway to only keep `gobblinJobState` here, instead of have
`configuration` object and `gobblinJobState` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
