[
https://issues.apache.org/jira/browse/GOBBLIN-977?focusedWorklogId=348421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348421
]
ASF GitHub Bot logged work on GOBBLIN-977:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 23:51
Start Date: 22/Nov/19 23:51
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2824: [GOBBLIN-977]
Update the misleading comments in BaseAbstractTask
URL:
https://github.com/apache/incubator-gobblin/pull/2824#issuecomment-557736359
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=h1)
Report
> Merging
[#2824](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/48d2eb56e0a6b1b570c7cf67489b566976574a66?src=pr&el=desc)
will **decrease** coverage by `41.47%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2824 +/- ##
============================================
- Coverage 45.62% 4.15% -41.48%
+ Complexity 8970 748 -8222
============================================
Files 1902 1902
Lines 71272 71273 +1
Branches 7862 7863 +1
============================================
- Hits 32518 2961 -29557
- Misses 35762 67994 +32232
+ Partials 2992 318 -2674
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../apache/gobblin/runtime/task/BaseAbstractTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGFzay9CYXNlQWJzdHJhY3RUYXNrLmphdmE=)
| `0% <0%> (-64.71%)` | `0 <0> (-6)` | |
|
[...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-5%)` | |
|
[...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=)
| `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
|
[.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-7%)` | |
|
[...ker/task/TaskLevelPolicyCheckerBuilderFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Rhc2svVGFza0xldmVsUG9saWN5Q2hlY2tlckJ1aWxkZXJGYWN0b3J5LmphdmE=)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...bblin/data/management/copy/AllEqualComparator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQWxsRXF1YWxDb21wYXJhdG9yLmphdmE=)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...blin/converter/string/ObjectToStringConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9zdHJpbmcvT2JqZWN0VG9TdHJpbmdDb252ZXJ0ZXIuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...rquet/JsonIntermediateToParquetGroupConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9Kc29uSW50ZXJtZWRpYXRlVG9QYXJxdWV0R3JvdXBDb252ZXJ0ZXIuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
| ... and [1100
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2824/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=footer).
Last update
[48d2eb5...5be2e0f](https://codecov.io/gh/apache/incubator-gobblin/pull/2824?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348421)
Time Spent: 20m (was: 10m)
> Remove/Update the mis-leading comments in BaseAbstractTask
> ----------------------------------------------------------
>
> Key: GOBBLIN-977
> URL: https://issues.apache.org/jira/browse/GOBBLIN-977
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Chen Guo
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The comments/instructions for the methods run() and commit() for
> BaseAbstractTask are wrong, and should be removed or updated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
