[
https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=348436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348436
]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/19 01:21
Start Date: 23/Nov/19 01:21
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2788: [GOBBLIN-939]
Integrate usage of env variables in gobblin scripts and standardize configs
URL:
https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1)
Report
> Merging
[#2788](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/48d2eb56e0a6b1b570c7cf67489b566976574a66?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2788 +/- ##
============================================
- Coverage 45.62% 45.62% -0.01%
+ Complexity 8970 8969 -1
============================================
Files 1902 1902
Lines 71272 71272
Branches 7862 7862
============================================
- Hits 32518 32516 -2
- Misses 35762 35764 +2
Partials 2992 2992
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.53% <0%> (+0.33%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2788/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=footer).
Last update
[48d2eb5...af58c46](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348436)
Time Spent: 2h 10m (was: 2h)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
