[
https://issues.apache.org/jira/browse/GOBBLIN-978?focusedWorklogId=348932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348932
]
ASF GitHub Bot logged work on GOBBLIN-978:
------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/19 05:48
Start Date: 25/Nov/19 05:48
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2825: GOBBLIN-978: Use
job start time instead of flow start time to kill jo…
URL:
https://github.com/apache/incubator-gobblin/pull/2825#issuecomment-558000801
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=h1)
Report
> Merging
[#2825](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/48d2eb56e0a6b1b570c7cf67489b566976574a66?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2825 +/- ##
============================================
+ Coverage 45.62% 45.62% +<.01%
- Complexity 8970 8971 +1
============================================
Files 1902 1902
Lines 71272 71283 +11
Branches 7862 7862
============================================
+ Hits 32518 32524 +6
- Misses 35762 35768 +6
+ Partials 2992 2991 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...a/org/apache/gobblin/runtime/api/SpecProducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY1Byb2R1Y2VyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh)
| `86.74% <100%> (+1.93%)` | `37 <3> (+3)` | :arrow_up: |
|
[.../service/monitoring/KafkaAvroJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUF2cm9Kb2JTdGF0dXNNb25pdG9yLmphdmE=)
| `51.66% <100%> (ø)` | `12 <0> (ø)` | :arrow_down: |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `79.25% <88.88%> (+0.33%)` | `12 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `35.51% <0%> (-3.74%)` | `12% <0%> (-1%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.74% <0%> (+0.46%)` | `30% <0%> (ø)` | :arrow_down: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2825/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=footer).
Last update
[48d2eb5...9f8ca60](https://codecov.io/gh/apache/incubator-gobblin/pull/2825?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348932)
Time Spent: 0.5h (was: 20m)
> Use job start time instead of flow start time to kill jobs stuck in
> ORCHESTRATED state
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-978
> URL: https://issues.apache.org/jira/browse/GOBBLIN-978
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current implementation uses flow start time instead of job start time to
> determine if a job has been stuck in the ORCHESTRATED state. This can
> incorrectly cancel jobs prematurely.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
