sv2000 commented on a change in pull request #2827: [COBBLIN-981]Handle
backward compatibility issue in HiveSource
URL: https://github.com/apache/incubator-gobblin/pull/2827#discussion_r351014623
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/source/HiveSource.java
##########
@@ -276,6 +279,11 @@ protected void
createWorkunitForNonPartitionedTable(HiveDataset hiveDataset, boo
}
}
+ @Deprecated
+ protected HiveWorkUnit workUnitForTable(HiveDataset hiveDataset) throws
IOException {
Review comment:
Can we just keep the older APIs and get rid of the methods where we pass
disableAvroCheck as an argument? Instead, we can just access this property via
the source state object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
