sv2000 commented on a change in pull request #2835: GOBBLIN-989: Track and
report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352909902
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractorStatsTracker.java
##########
@@ -249,6 +263,7 @@ public void updateStatisticsForCurrentPartition(int
partitionIdx, long readStart
this.workUnitState.setProp(KafkaUtils.getPartitionPropName(KafkaSource.STOP_FETCH_EPOCH_TIME,
partitionId),
Long.toString(stats.getStopFetchEpochTime()));
tagsForPartition.put(PROCESSED_RECORD_COUNT,
Long.toString(stats.getProcessedRecordCount()));
+ tagsForPartition.put(SLA_MISSED_RECORD_COUNT,
Long.toString(stats.getSlaMissedRecordCount()));
Review comment:
Good point. I initialized the SLA_MISSED_RECORD_COUNT to -1. In case, SLA is
configured the count should be >= 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
