[
https://issues.apache.org/jira/browse/GOBBLIN-989?focusedWorklogId=352295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352295
]
ASF GitHub Bot logged work on GOBBLIN-989:
------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/19 23:19
Start Date: 02/Dec/19 23:19
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2835: GOBBLIN-989:
Track and report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352911689
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -176,7 +176,12 @@ public D readRecordImpl(D reuse) throws
DataRecordException, IOException {
D record = decodeKafkaMessage(nextValidMessage);
- this.statsTracker.onDecodeableRecord(this.currentPartitionIdx,
readStartTime, decodeStartTime, nextValidMessage.getValueSizeInBytes());
+ long logAppendTime = 0L;
+ if (nextValidMessage.isTimestampLogAppend()) {
Review comment:
Yes. Record Create time is a little tricky since we have not control over
record creation and SLA misses based on create time may result in false
positives. Having said that, I think it would be useful to have another metric
to track the average delay between record creation time and extract time. Can
be a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352295)
Time Spent: 1h 40m (was: 1.5h)
> Track and report record level SLA in Gobblin Kafka Extractor tracking event
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-989
> URL: https://issues.apache.org/jira/browse/GOBBLIN-989
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Track record level SLA in Gobblin Kafka Extractor tracking events. The SLA is
> measured as the difference between extract time and the log append time on
> the Kafka broker, if available in the Kafka consumer record.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
