Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate 
usage of env variables in gobblin scripts and standardize configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r353352604
 
 

 ##########
 File path: conf/gobblin-as-service/application.conf
 ##########
 @@ -16,11 +16,12 @@
 #
 
 # Gobblin-As-Service configuration properties
-gobblin.service.work.dir=/tmp/gobblin-as-service
+gobblin.work.dir=${GOBBLIN_WORK_DIR}
 
 Review comment:
   So I tested the scripts and some execution modes still seem to have 
references to the old variable of the old directory 
e.g.`gobblin.service.work.dir`. Could we fix these to ensure the scripts are 
all working?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to