sv2000 commented on a change in pull request #2837: [GOBBLIN-992]Make
parallelRunner timeout configurable in MRJobLauncher
URL: https://github.com/apache/incubator-gobblin/pull/2837#discussion_r353456109
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -621,7 +623,11 @@ private void addHdfsJars(String hdfsJarFileList,
Configuration conf) throws IOEx
private void prepareJobInput(List<WorkUnit> workUnits) throws IOException {
Closer closer = Closer.create();
try {
- ParallelRunner parallelRunner = closer.register(new
ParallelRunner(this.parallelRunnerThreads, this.fs));
+ // Specify timeout on waiting for all workunits to be persisted as
usually it could take long when
Review comment:
Why not simply do parallelJobRunner.waitForTasks(Long.MAX_VALUE) in
prepareJobInput? A pre-defined fixed timeout setting may not be ideal, since
the timeout should ideally depend on the number of workunits created which may
vary from run to run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
