[
https://issues.apache.org/jira/browse/GOBBLIN-993?focusedWorklogId=353966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353966
]
ASF GitHub Bot logged work on GOBBLIN-993:
------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 01:08
Start Date: 05/Dec/19 01:08
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2839: [GOBBLIN-993]
Support job level hive configuration override
URL: https://github.com/apache/incubator-gobblin/pull/2839#discussion_r354065480
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveMetastoreClientPool.java
##########
@@ -66,6 +69,10 @@
public static final String POOL_MIN_EVICTABLE_IDLE_TIME_MILLIS =
"pool.min.evictable.idle.time.millis";
+ public static final String POOL_HIVE_EXTRA_CONFIG_PREFIX =
"hive.extraConfig.";
Review comment:
hive.extraConfig sounds awkward. Can we rename to hive.additionalProps or
hive.additionalConfig?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 353966)
Time Spent: 20m (was: 10m)
> Support job level hive configuration override
> ---------------------------------------------
>
> Key: GOBBLIN-993
> URL: https://issues.apache.org/jira/browse/GOBBLIN-993
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
