[
https://issues.apache.org/jira/browse/GOBBLIN-998?focusedWorklogId=355498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355498
]
ASF GitHub Bot logged work on GOBBLIN-998:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 23:12
Start Date: 06/Dec/19 23:12
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2843: [GOBBLIN-998]
ExecutionStatus should be reset to PENDING before a job retries
URL:
https://github.com/apache/incubator-gobblin/pull/2843#issuecomment-562775420
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=h1)
Report
> Merging
[#2843](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/2bbf42bbc47ce76597180066007164d385f64565?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2843 +/- ##
============================================
+ Coverage 45.65% 45.66% +<.01%
- Complexity 8984 8985 +1
============================================
Files 1903 1903
Lines 71331 71331
Branches 7873 7873
============================================
+ Hits 32566 32570 +4
Misses 35764 35764
+ Partials 3001 2997 -4
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==)
| `66.66% <0%> (ø)` | `14 <0> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <0%> (-2.81%)` | `11% <0%> (-1%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.81% <0%> (+1.38%)` | `28% <0%> (+1%)` | :arrow_up: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2843/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=footer).
Last update
[2bbf42b...6b4878e](https://codecov.io/gh/apache/incubator-gobblin/pull/2843?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 355498)
Time Spent: 0.5h (was: 20m)
> ExecutionStatus should be reset to PENDING before a job retries
> ---------------------------------------------------------------
>
> Key: GOBBLIN-998
> URL: https://issues.apache.org/jira/browse/GOBBLIN-998
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Chen Guo
> Priority: Critical
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In the modifyStateIfRetryRequired of KafkaJobStatusMonitor, when the state is
> Failed and currentAttempts < maxAttempts, the ExecutionStatus is set to
> Running.
> However, due to the checkin from
> GOBBLIN-974([https://github.com/apache/incubator-gobblin/blob/9f50a2563cc257039da44018663b6b9e119fb499/gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java#L159]),
> the currentAttempts update from a lower-order event(like Orchestrated)
> cannot be consumed to update the jobState file. Thus it will cause infinite
> retries in DagManagerThread for failed jobs when it poolAndAdvanceDag.
>
> The solution is to update ExecutionStatus to PENDING instead of Running.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
