[
https://issues.apache.org/jira/browse/GOBBLIN-999?focusedWorklogId=355500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355500
]
ASF GitHub Bot logged work on GOBBLIN-999:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 23:32
Start Date: 06/Dec/19 23:32
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2844: [GOBBLIN-999]
Separate Hive-Avro type related constants out of Avro2ORC specific module
URL:
https://github.com/apache/incubator-gobblin/pull/2844#issuecomment-562781864
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=h1)
Report
> Merging
[#2844](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/2bbf42bbc47ce76597180066007164d385f64565?src=pr&el=desc)
will **decrease** coverage by `0.03%`.
> The diff coverage is `9.52%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2844 +/- ##
============================================
- Coverage 45.65% 45.61% -0.04%
- Complexity 8984 8986 +2
============================================
Files 1903 1904 +1
Lines 71331 71333 +2
Branches 7873 7873
============================================
- Hits 32566 32540 -26
- Misses 35764 35794 +30
+ Partials 3001 2999 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=)
| `64.78% <57.14%> (-2.36%)` | `84 <0> (ø)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2844/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=footer).
Last update
[2bbf42b...a0fad08](https://codecov.io/gh/apache/incubator-gobblin/pull/2844?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 355500)
Time Spent: 20m (was: 10m)
> Refactor Hive-Avro related constants to make it reusable
> --------------------------------------------------------
>
> Key: GOBBLIN-999
> URL: https://issues.apache.org/jira/browse/GOBBLIN-999
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)