[
https://issues.apache.org/jira/browse/GOBBLIN-1000?focusedWorklogId=356476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356476
]
ASF GitHub Bot logged work on GOBBLIN-1000:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/19 19:12
Start Date: 09/Dec/19 19:12
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2845: GOBBLIN-1000: Add
min and max LogAppendTime to tracking events emitte…
URL:
https://github.com/apache/incubator-gobblin/pull/2845#issuecomment-563387337
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=h1)
Report
> Merging
[#2845](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/ded6ac1115ff67373daa90b64d33bc63b8a7390b?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2845 +/- ##
============================================
+ Coverage 45.61% 45.62% +0.01%
- Complexity 8983 8986 +3
============================================
Files 1904 1904
Lines 71333 71343 +10
Branches 7873 7875 +2
============================================
+ Hits 32535 32547 +12
+ Misses 35799 35795 -4
- Partials 2999 3001 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh)
| `54.54% <50%> (-0.32%)` | `25 <0> (ø)` | |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.81% <0%> (+0.92%)` | `28% <0%> (+1%)` | :arrow_up: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2845/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=footer).
Last update
[ded6ac1...626a028](https://codecov.io/gh/apache/incubator-gobblin/pull/2845?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 356476)
Time Spent: 40m (was: 0.5h)
> Add min and max LogAppendTime to tracking events emitted from Gobblin Kafka
> Extractor
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1000
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1000
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add min and max logAppendTimes to the tracking events to better track sla
> misses.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)