[
https://issues.apache.org/jira/browse/GOBBLIN-972?focusedWorklogId=357513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357513
]
ASF GitHub Bot logged work on GOBBLIN-972:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/19 23:42
Start Date: 10/Dec/19 23:42
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2848: [GOBBLIN-972] Make
DEFAULT_NUM_THREADS in DagManager public
URL:
https://github.com/apache/incubator-gobblin/pull/2848#issuecomment-564308805
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=h1)
Report
> Merging
[#2848](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/0469447f0732bf61a39d38af45e8c84715f87853?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2848 +/- ##
============================================
+ Coverage 45.62% 45.62% +<.01%
- Complexity 8988 8991 +3
============================================
Files 1904 1904
Lines 71349 71349
Branches 7876 7876
============================================
+ Hits 32551 32554 +3
Misses 35795 35795
+ Partials 3003 3000 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `79.36% <100%> (ø)` | `12 <0> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `63.42% <0%> (-1.39%)` | `27% <0%> (-1%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0%> (ø)` | `4% <0%> (+1%)` | :arrow_up: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2848/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=footer).
Last update
[0469447...351ea4a](https://codecov.io/gh/apache/incubator-gobblin/pull/2848?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 357513)
Time Spent: 0.5h (was: 20m)
> Make DEFAULT_NUM_THREADS in DagManager public
> ----------------------------------------------
>
> Key: GOBBLIN-972
> URL: https://issues.apache.org/jira/browse/GOBBLIN-972
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Chen Guo
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Make DEFAULT_NUM_THREADS in DagManager public such that it can be referenced
> in other places.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
