autumnust commented on a change in pull request #2846: [GOBBLIN-1001] Implement
TimePartitionGlobFinder
URL: https://github.com/apache/incubator-gobblin/pull/2846#discussion_r357312011
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/dataset/DefaultFileSystemGlobFinder.java
##########
@@ -33,16 +33,6 @@ public DefaultFileSystemGlobFinder(FileSystem fs,
Properties properties) throws
}
public FileSystemDataset datasetAtPath(final Path path) throws IOException {
- return new FileSystemDataset() {
Review comment:
There are more than one places that having this anonymous class impl. Shall
we refactor them all if you would like to replace it with the real impl. ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
